Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS #56

Open
alihs opened this issue Sep 23, 2015 · 11 comments
Open

iOS #56

alihs opened this issue Sep 23, 2015 · 11 comments

Comments

@alihs
Copy link

alihs commented Sep 23, 2015

The styles generated by cssstyle.io are not rendering on iOS. Can you confirm this please?
I need help.

an example would be a sub class {./--} not rendering
@geddski
Copy link
Owner

geddski commented Sep 23, 2015

Do you mean in mobile safari? Also if you could paste a small sample that
would help me debug the issue. It's likely that your HTML is just missing
the right classes.
On Wed, Sep 23, 2015 at 10:09 AM alihs notifications@github.com wrote:

The styles generated by cssstyle.io are not rendering on iOS. Can you
confirm this please?
I need help.

—
Reply to this email directly or view it on GitHub
#56.

@alihs
Copy link
Author

alihs commented Sep 23, 2015 

<div class=“banner-box --bg-green”></div>

any styles on --bg-green doesnot come through on iOS safari and Windows Phone native browser

@geddski
Copy link
Owner

geddski commented Sep 23, 2015

can you share your banner-box component (and bg-green option)?

@alihs
Copy link
Author

alihs commented Sep 23, 2015 

<body id="EXAMPLE">

    <div class="banner-box --bg-green">
        This is a banner with a green background.
    </div>

    <div class="banner-box --bg-blue">
        This is a banner with a blue background.
    </div>

</body>

@include component(banner-box){
    padding: 30px;
    color: white;
    background-color: red;
    margin-bottom: 30px;
    text-align: center;

    @include option(bg-green){
        background-color: green;
    }

    @include option(bg-blue){
        background-color: blue;
    }
}

it is a very basic example. none of the option classes that are not rendering on IOS Safari and Micorosft Windows Phone

@geddski
Copy link
Owner

geddski commented Sep 23, 2015

hmm, that should work just fine. Does it work on desktop chrome?

@geddski
Copy link
Owner

geddski commented Sep 23, 2015

It's also possible that your sass hasn't run again since adding those options. Take a look at the compiled CSS file and see if it has them.

@alihs
Copy link
Author

alihs commented Sep 23, 2015

Works fine on desktop and compiles fine as well. Is it working fine on your iOS?

Ali Hussain

-----Original Message-----
From: "Dave Geddes" notifications@github.com
Sent: ‎9/‎23/‎2015 10:42 PM
To: "geddski/csstyle" csstyle@noreply.github.com
Cc: "alihs" alihussain707@gmail.com
Subject: Re: [csstyle] iOS (#56)

It's also possible that your sass hasn't run again since adding those options. Take a look at the compiled CSS file and see if it has them.
—
Reply to this email directly or view it on GitHub.

@geddski
Copy link
Owner

geddski commented Sep 23, 2015

yeah works just fine. csstyle.io is built with it, looks great on mobile. Maybe your CSS is being cached on mobile safari?

@alihs
Copy link
Author

alihs commented Sep 28, 2015

totally strange. my desktop site works fine but the mobile site is acting weird. Could it be a utf-8 issues?

@geddski
Copy link
Owner

geddski commented Dec 17, 2015

I think I figured out the cause of the issue. I believe csstyle is missing an escape somewhere. In Chrome if your CSS has a .--card class, it will render just fine. On iOS it won't, unless you escape it properly: \.--card. I'll try to track down where this might be happening.

@alihs
Copy link
Author

alihs commented Dec 17, 2015

Thanks.
Also i too forgot to update, it was my css compressing engine that was
doing this.
I had to add a few rules to it and it worked.

  • Ali Hussain

On Thu, Dec 17, 2015 at 12:35 PM, Dave Geddes notifications@github.com
wrote:

I think I figured out the cause of the issue. I believe csstyle is missing
an escape somewhere. In Chrome if your CSS has a .--card class, it will
render just fine. On iOS it won't, unless you escape it properly: .--card.
I'll try to track down where this might be happening.

—
Reply to this email directly or view it on GitHub
#56 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geddski @alihs