bug in converting a commented out function

[profLewis]

• geemap version:
  geemap.version_info -> (0, 13, 3)

• Python version:
  Python 3.6.10 :: Anaconda, Inc.

• Operating System:
  Darwin Kernel Version 19.6.0

Description

Trying to do:
Use js_to_python from geemap.conversion to convert a javascript gee code

Tell us what happened, what went wrong, and what you expected to happen:

bug in converting a commented out function

The js line:

// var s2_cloud = function(image){

gets converted to

def # s2_cloud(image):

See below. for run

What I Did

• setup googlesource login to allow pull of earth engine public repos

• clone example code

git clone https://earthengine.googlesource.com/users/marcyinfeng/utils
cd utils

• example python code: example.py

from pathlib import Path        
from geemap.conversion import *

jsfile = 'SIAC_lai_accurate'
infile   = Path(jsfile).absolute().as_posix() 
outfile =  Path(jsfile + '.py').absolute().as_posix() 
retcode = js_to_python(infile,outfile)

• run conversion
  python example.py
• test result
  python SIAC_lai_accurate.py
  result:

File "SIAC_lai_accurate.py", line 51
   def # s2_cloud(image):
                        ^
SyntaxError: invalid syntax

[giswqs]

@profLewis Thank you for reporting this bug. I just committed code to fix this bug. Please update geemap using geemap.update_package() or pip install git+https://github.com/giswqs/geemap and try your code again.

[giswqs]

Here is what it looks like: