Add radio options to ensure that gamma and palette are not set at the same time #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
naschmitz
reviewed
Jun 21, 2024
naschmitz
approved these changes
Jul 26, 2024
giswqs
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EE API disallows setting the gamma and palette
vis_paramsat the same time. To account for this on the Code Editor, we use radio options, which is also disabled when the RGB band selector is selected.I emulated this behavior such that when the 1 band option is set, we get both gamma and palette options, but when in rgb bands are selected, only the gamma slider is set.
I also made sure that the palette and gamma options are persistent between options clicked.
Also
gammaandpaletteparams passed intoadd_layerare also reflected.TODO: Add unit tests
Tested on jupyter-lab locally and Colab: https://colab.research.google.com/drive/1Y_3iZp7FREo_hLsqycaaTvnM7xBjIBeq?usp=sharing