Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: relaxed json support (json5) #42

Closed
tomsquest opened this issue Apr 1, 2024 · 1 comment
Closed

feature: relaxed json support (json5) #42

tomsquest opened this issue Apr 1, 2024 · 1 comment
Labels
feature

Comments

@tomsquest
Copy link

tomsquest commented Apr 1, 2024 •
edited
Loading

Hi,

In Kibana Devtools, it is very annoying to "fix" you data to be json, adding double quotes and comma, but not too much comma else there is a syntax error.

image

This feature idea is to use a relaxed json option, for example, using json5 in the editor and converting the json5 to json before sending to Elastic. This would allow a syntax that is way more fast to type, and so convenient.

Today, DocKit seems to run the relaxed json (without syntax highlighting), but the result fails ES side.

image
@tomsquest tomsquest changed the title feature: relaxed json support feature: relaxed json support (json5) Apr 1, 2024
@Blankll Blankll added the feature label Apr 1, 2024
@Blankll Blankll mentioned this issue Jul 7, 2024
Closed
7 tasks
@Blankll Blankll mentioned this issue Aug 19, 2024
Merged
Blankll added a commit that referenced this issue Aug 22, 2024
@Blankll
feat: json5 as QueryDSL format (#90)
4b1ea22 
feat: enable JSON5 support
- json5 highlight
- json5 covert to JSON when requesting  the server
- json5 format


Refs: #57 #42

---------

Signed-off-by: seven <zilisheng1996@gmail.com>
@Blankll Blankll mentioned this issue Aug 24, 2024
Merged
Blankll added a commit that referenced this issue Sep 3, 2024
@Blankll
feat: Query DSL auto-complete (#93)
b523f18 
feat: enable Query DSL auto-complete


Refs: #57 #42

---------

Signed-off-by: seven <zilisheng1996@gmail.com>
@Blankll Blankll mentioned this issue Sep 5, 2024
Merged
Blankll added a commit that referenced this issue Sep 5, 2024
@Blankll
feat: render/highlight error syntax (#98)
9875ed9 
feat: render/highlight error syntax

with json5 enabled, to highlight invalid tokens with different colors to
improve user experience

Refs: #57 #42

---------

Signed-off-by: seven <zilisheng1996@gmail.com>
@Blankll
Copy link
Member

Blankll commented Sep 6, 2024

Hi there, it's been a while but JSON5 has finally been enabled, big welcome for people to explore,
I'm going close this issue, but feel free to raise another if any bug/improvement there

@Blankll Blankll closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomsquest @Blankll