Epic/support dynamo db #144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blankll
reviewed
Dec 14, 2024
Comment on lines
+125
to
+146
| async saveConnection(connection:Connection) { | ||
| try { | ||
| if (connection.id) { | ||
| const index = this.connections.findIndex(c => c.id === connection.id); | ||
| if (index !== -1) { | ||
| this.connections[index] = connection; | ||
| } | ||
| } else { | ||
| connection.id = this.connections.length + 1; | ||
| this.connections.push(connection); | ||
| } | ||
|
|
||
| try { | ||
| await storeApi.set('connections', pureObject(this.connections)); | ||
| } catch (error) { | ||
| console.warn('Failed to persist connections:', error); | ||
| } | ||
|
|
||
| return connection; | ||
| } catch (error) { | ||
| console.error('Error saving connection:', error); | ||
| throw error; |
There was a problem hiding this comment.
store the type to type like DatabaseType.ELASTICSEARCH to storeApi.set, it should help to simplify the fetchConnections as well?
Blankll
reviewed
Dec 14, 2024
Comment on lines
+214
to
+219
| if (!(error instanceof Error && error.message.includes('__TAURI_IPC__'))) { | ||
| if (error instanceof Error) { | ||
| message.error(error.message); | ||
| } else { | ||
| message.error(lang.t('connection.unknownError')); | ||
| } |
There was a problem hiding this comment.
it looks worth encapsulating the error inside saveConnection, so On UI page it only needs to care about showing the message ?
Blankll
reviewed
Dec 14, 2024
Comment on lines
+286
to
+294
| try { | ||
| await client.send(new ListTablesCommand({})); | ||
| return true; | ||
| } catch (error) { | ||
| if (error instanceof Error) { | ||
| throw new Error(error.message); | ||
| } | ||
| throw new Error('Unknown error occurred while testing connection'); | ||
| } |
There was a problem hiding this comment.
@aws-sdk/client-dynamodb should not able to run here, since all ts/vue content running in browser rather than nodejs, so to call the dynamodb,
vue -> rust dynamo lib -> dynamodb
There was a problem hiding this comment.
Oh, yes! You are right! I will update soon
Blankll
reviewed
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat|fix|refactor: summary title of the PR
Refs: #142