Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes on links that only have # as value for href #13

Closed
wants to merge 1 commit into from

Conversation

michaellopez
Copy link

Basically this:

<a href="#">Crash it!</a>

will crash the build:

Pushstate server started on port 2999

🕷   Starting crawling http://localhost:2999
TypeError: Parameter "url" must be a string, not object
    at Url.parse (url.js:87:11)
    at urlParse (url.js:81:5)
    at Url.resolve (url.js:641:29)
    at Object.urlResolve [as resolve] (url.js:637:40)
    at /app/node_modules/react-snapshot/lib/Crawler.js:96:44
    at Array.forEach (native)
    at /app/node_modules/react-snapshot/lib/Crawler.js:88:83
    at Array.forEach (native)
    at Crawler.extractNewLinks (/app/node_modules/react-snapshot/lib/Crawler.js:86:36)
    at /app/node_modules/react-snapshot/lib/Crawler.js:68:15

This PR just makes the Crawler ignore it and continue crawling.

@geelen
Copy link
Owner

geelen commented Apr 27, 2017

Closing in favour of #20

@geelen geelen closed this Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants