Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Issue #1068: Add php-yaml as a default php package #1073

Merged
merged 1 commit into from
Dec 23, 2016

Conversation

oxyc
Copy link
Collaborator

@oxyc oxyc commented Dec 22, 2016

This is still entirely untested. Hopefully I'll get time to locally test it later today.

@geerlingguy
Copy link
Owner

Looks good enough to me. I won't have time to test locally today, so if you get a chance let me know!

@oxyc
Copy link
Collaborator Author

oxyc commented Dec 23, 2016

Travis to the rescue! https://travis-ci.org/geerlingguy/drupal-vm/builds/186236162 (rebased away 5634f00)

Worked on Ubuntu 16.04 and Centos7 with all php versions, with the exception of PHP 5.5 on Ubuntu. Looks like ondrej might have finally removed it https://travis-ci.org/geerlingguy/drupal-vm/jobs/186236165#L666.

RTBM

@geerlingguy
Copy link
Owner

PHP 5.5 isn't officially supported by Drupal VM anymore (nor is it supported by PHP :D), so that's not an issue I care to deal with. Ship it!

@geerlingguy geerlingguy merged commit 8659ba7 into geerlingguy:master Dec 23, 2016
@oxyc oxyc deleted the php-yaml branch April 24, 2017 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants