-
-
Notifications
You must be signed in to change notification settings - Fork 642
Create new solr collection instead of using the default one. #1134
Conversation
@@ -7,29 +7,27 @@ | |||
# `solr` in the `installed_extras`, and is currently set up for the D7 versions | |||
# of Apache Solr Search or Search API Solr. | |||
|
|||
SOLR_SETUP_COMPLETE_FILE=/etc/drupal_vm_solr_config_complete | |||
NAME="drupalvm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change—one thing though, let's set the default to d8
, just because that's what the D8 version of the Search API Solr Defaults module sets up in it's default index.
This would make the setup pretty much plug-and-play, as you'd immediately have a populated and working search index and search page after enabling the defaults module, as shown here: http://www.jeffgeerling.com/blog/2017/setting-faceted-apache-solr-search-drupal-8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second that motion! I didn't know there is a default provided in Search API Solr Search because I am currently using Apache Solr Search. Let me do the change.
d8 is the default of apache_api_solr module.
@@ -7,29 +7,27 @@ | |||
# `solr` in the `installed_extras`, and is currently set up for the D7 versions | |||
# of Apache Solr Search or Search API Solr. | |||
|
|||
SOLR_SETUP_COMPLETE_FILE=/etc/drupal_vm_solr_config_complete | |||
NAME="d8" | |||
SOLR_SETUP_COMPLETE_FILE="/etc/drupal_vm_solr_config_complete_"$NAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This $NAME
should go inside the double quotes.
|
||
# Search API Solr module. | ||
SOLR_DOWNLOAD="http://ftp.drupal.org/files/projects/search_api_solr-8.x-1.x-dev.tar.gz" | ||
SOLR_DOWNLOAD_DIR="/tmp" | ||
SOLR_MODULE_NAME="search_api_solr" | ||
SOLR_VERSION="5.x" | ||
SOLR_CORE_PATH="/var/solr/data/collection1" | ||
SOLR_CORE_PATH="/var/solr/data/"$NAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here (inside double quotes).
This pull request has implemented the suggestion I raised in #1133