Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Create new solr collection instead of using the default one. #1134

Merged
merged 4 commits into from
Jan 23, 2017

Conversation

jimmyko
Copy link
Contributor

@jimmyko jimmyko commented Jan 20, 2017

This pull request has implemented the suggestion I raised in #1133

@jimmyko jimmyko closed this Jan 20, 2017
@jimmyko jimmyko changed the title geerlingguy/drupal-vm#1133 Create new solr collection instead of using the default one. Create new solr collection instead of using the default one. Jan 20, 2017
@jimmyko jimmyko reopened this Jan 20, 2017
@@ -7,29 +7,27 @@
# `solr` in the `installed_extras`, and is currently set up for the D7 versions
# of Apache Solr Search or Search API Solr.

SOLR_SETUP_COMPLETE_FILE=/etc/drupal_vm_solr_config_complete
NAME="drupalvm"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change—one thing though, let's set the default to d8, just because that's what the D8 version of the Search API Solr Defaults module sets up in it's default index.

This would make the setup pretty much plug-and-play, as you'd immediately have a populated and working search index and search page after enabling the defaults module, as shown here: http://www.jeffgeerling.com/blog/2017/setting-faceted-apache-solr-search-drupal-8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second that motion! I didn't know there is a default provided in Search API Solr Search because I am currently using Apache Solr Search. Let me do the change.

d8 is the default of apache_api_solr module.
@@ -7,29 +7,27 @@
# `solr` in the `installed_extras`, and is currently set up for the D7 versions
# of Apache Solr Search or Search API Solr.

SOLR_SETUP_COMPLETE_FILE=/etc/drupal_vm_solr_config_complete
NAME="d8"
SOLR_SETUP_COMPLETE_FILE="/etc/drupal_vm_solr_config_complete_"$NAME
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This $NAME should go inside the double quotes.


# Search API Solr module.
SOLR_DOWNLOAD="http://ftp.drupal.org/files/projects/search_api_solr-8.x-1.x-dev.tar.gz"
SOLR_DOWNLOAD_DIR="/tmp"
SOLR_MODULE_NAME="search_api_solr"
SOLR_VERSION="5.x"
SOLR_CORE_PATH="/var/solr/data/collection1"
SOLR_CORE_PATH="/var/solr/data/"$NAME
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here (inside double quotes).

@geerlingguy geerlingguy merged commit 2d68f03 into geerlingguy:master Jan 23, 2017
geerlingguy added a commit that referenced this pull request Jan 23, 2017
kekkis pushed a commit to kekkis/drupal-vm that referenced this pull request Feb 23, 2017
sonfd pushed a commit to sonfd/drupal-vm that referenced this pull request May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants