Add Selenium and Firefox to vm to power Behat tests #161
Conversation
| @@ -155,3 +156,6 @@ php_xdebug_default_enable: 0 | |||
| solr_version: "4.10.4" | |||
| solr_xms: "64M" | |||
| solr_xmx: "128M" | |||
|
|
|||
| # Selenium configuration | |||
| server_version: 2.46.0 | |||
There was a problem hiding this comment.
Can this be updated (upstream) to a variable with the name of the role prefixed (e.g. selenium_server_version)? Similar to Drupal modules, it's best to use a prefixed variable name so there are no conflicts between roles (and to clarify what, exactly, the variable is used for in a large config file).
There was a problem hiding this comment.
Actually, it looks like the variable is selenium_version upstream... is that correct?
There was a problem hiding this comment.
yeah, it should have been selenium_version. Fixed.
|
One other question: Would you be willing to (or would you accept a PR from me to) make |
|
@geerlingguy let me give it a shot to get it working on RHEL/CentOS. |
|
@arknoll - Great! let me know when that's done, and I'll un-postpone this PR. |
geerlingguy
changed the title
geerlingguy
changed the title
|
@geerlingguy Done and tested on CentOS https://galaxy.ansible.com/list#/roles/4340. |
|
Great! I'll merge and do some more testing tonight. |
PR #161: Add Selenium and Firefox to power Behat tests.
|
Verified that behat/selenium/firefox/etc. works great across all supported CentOS and Ubuntu versions. |
Relates to #137
Notes/TODOs from @geerlingguy:
composer global require'd packages more accessible (see Make globally-required Composer packages accessible to vagrant user #154)