-
-
Notifications
You must be signed in to change notification settings - Fork 642
Conversation
@@ -1,6 +1,8 @@ | |||
--- | |||
- src: arknoll.selenium | |||
version: 1.2.0 | |||
- src: beetboxvm.upload-progress | |||
version: master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a release? I've learned from past experience that I need to lock in specific versions for stability reasons—especially with things like PHP extensions which can have problems with new OS/PHP version combos.
Also, since this role doesn't currently support RHEL/CentOS, I would rather not include it since there are a large number of users (myself included) who generally use the centos7 box instead of Ubuntu...
@geerlingguy done -- there's no specific Ubuntu tasks so should support all platforms. |
Also no worries if you wanted to maintain this as |
Whilst we don't necessarily want to maintain roles we're more than happy to push PRs upstream and have made it really easy to do this by checking out roles directly from the source repo in debug mode. https://github.com/beetboxvm/beetbox/blob/master/provisioning/ansible/playbook-roles.yml#L32-L38 |
@thom8 - If you're willing to maintain the role (it seems it would be relatively minimal... but it does take a little effort over time), I'm okay with using it (I use If you're not interested in maintaining the role, I'd be willing to fork it and take it over, but only if you don't want it. |
Don't mind either way just thought that you're probably better placed to It's very similar to your xdebug and xhprof roles. |
I'm happy to maintain it so I'll transfer it to my account and update tests for both platforms. |
@geerlingguy what would you recommend as your best role for multi platform tests? |
All done & tests are passing on CentOS 7, Ubuntu 12.04 & 14.04 https://travis-ci.org/thom8/ansible-role-php-upload-progress |
It looks like 1.0.1 isn't available on Galaxy yet:
https://galaxy.ansible.com/thom8/php-upload-progress/ Note that you can have Travis push updated tags directly to Galaxy if you get your travis token from your Travis CI settings page (on left side near top), then go to Galaxy, 'My Roles', then click on the settings widget for your role and add in the token. Then you add the |
Thanks -- rebuilding now |
@geerlingguy - anything outstanding on this one? |
I promise I'll get back to this soon. Sorry for the delays in review! |
Says the guy who keeps putting it off... I'm working on a 3.6.0 release very soon—any chance you can fix the conflicts, @thom8 ? |
2bcf3c2
to
442eb27
Compare
@geerlingguy done -- also changed to be conditionally installed and included |
442eb27
to
03b40cf
Compare
Beautiful! Thanks for your work on this. It may become a default at some point... but maybe not, since it's one of those things that people don't often add in (if they don't get it OOTB) unless they actually need it. |
Add role to install the uploadprogress extension -- https://pecl.php.net/package/uploadprogress
role :: https://github.com/beetboxvm/ansible-role-beetbox-upload-progress