This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
Remove duplicate integration tests #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxyc
force-pushed
the
reduce-ci-tasks
branch
from
c7aea24 to
52e5214
Compare
oxyc
force-pushed
the
reduce-ci-tasks
branch
from
c810639 to
32b8c03
Compare
|
Looks good, shaves off a couple minutes from the build. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's really no reason to test the extra utilities for the pgsql integration test as everything has already been tested in the default scenario.
I also removed the xhprof integration test so we don't have to define the
installed_extrasvariable but can reuse it fromdefault.config.yml. I imagine we're mostly interested in knowing that the virtual hosts are created in all scenarios and we already test that with adminer and PML.