ISSUE-16 - Add unit tests #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit testing to several of the newly refactored modules, ahead of migrating to use cargo_metadata Unit tests added to: * cli * format - print * format - table * format - tree * format * graph * rs_file * scan * traversal
anderejd
approved these changes
Sep 9, 2020
| @@ -152,27 +167,66 @@ pub fn print_text_tree_lines_as_table( | |||
| let name = name.unwrap(); | |||
|
|
|||
| // TODO: Fix the alignment on macOS (others too?) | |||
| println!("{}{}{}", table_row_empty(), tree_vines, name); | |||
There was a problem hiding this comment.
Nice! This change was long overdue :)
| @@ -8,20 +8,21 @@ use cargo::core::PackageId; | |||
| pub enum TextTreeLine { | |||
| /// A text line for a package | |||
| Package { id: PackageId, tree_vines: String }, | |||
| /// There're extra dependencies comming and we should print a group header, | |||
| /// There are extra dependencies coming and we should print a group header, | |||
Comment on lines
+154
to
+160
| add_graph_node_if_not_present_and_edge( | ||
| dependency, | ||
| dependency_package_id, | ||
| graph, | ||
| index, | ||
| pending_packages, | ||
| ); |
|
Awesome! Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit testing to several of the newly refactored modules, ahead of
migrating to use cargo_metadata
Unit tests added to: