ISSUE-16 - Remove no longer needed mapping functions: #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moving functions which are still required to test parity to code only compiled in tests * Adding a fix for edge case stumbled upon by mistake, where dependencies can be duplicated * Removing explicit use of `cargo_metadata::PackageId` outside of `mapping` module Signed-off-by: joshmc <josh-mcc@tiscali.co.uk>
|
This PR should take us past the line on #16 finally! |
|
Seriously great work on #16! 🥇 |
jmcconnell26
pushed a commit
to jmcconnell26/cargo-geiger
that referenced
this pull request
Dec 2, 2020
…ongerNeededMappingFunctions ISSUE-16 - Remove no longer needed mapping functions: Signed-off-by: joshmc <josh-mcc@tiscali.co.uk>
jmcconnell26
pushed a commit
to jmcconnell26/cargo-geiger
that referenced
this pull request
Dec 2, 2020
…ongerNeededMappingFunctions ISSUE-16 - Remove no longer needed mapping functions: Signed-off-by: joshmc <josh-mcc@tiscali.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiled in tests
dependencies can be duplicated
cargo_metadata::PackageIdoutside ofmappingmoduleSigned-off-by: joshmc josh-mcc@tiscali.co.uk