Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(use-click-away): update handler reference #720

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix(use-click-away): update handler reference #720

merged 1 commit into from
Feb 8, 2022

Conversation

tmkx
Copy link
Contributor

@tmkx tmkx commented Feb 8, 2022

Checklist

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

  1. The handler should be updated if changed.
  2. replace Event with MouseEvent

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #720 (de48736) into master (2b8f448) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         198      198           
  Lines        3030     3030           
  Branches      668      668           
=======================================
  Hits         2996     2996           
  Misses         33       33           
  Partials        1        1           
Impacted Files Coverage Δ
components/use-click-away/use-click-away.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8f448...de48736. Read the comment docs.


rerender()
simulateNativeClick(document.body)
expect(handler2).toHaveBeenCalled()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handler1 should not be called?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handler1 and handler2 should be called once each in this test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion is mainly ensure handler2 has been called.

Copy link
Member

@unix unix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@unix
Copy link
Member

unix commented Feb 8, 2022

Thanks for your contribution, if you have no other changes we can just merge?
And, do we need to publish a patch version? @tmkx (if you need it)

@unix unix assigned unix and tmkx Feb 8, 2022
@unix unix added the type: bug Something isn't working label Feb 8, 2022
@tmkx
Copy link
Contributor Author

tmkx commented Feb 8, 2022

And, do we need to publish a patch version? @tmkx (if you need it)

Just merge, no patch version is needed, thx.

@unix unix merged commit e80dabd into geist-org:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants