-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(use-click-away): update handler reference #720
Conversation
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 198 198
Lines 3030 3030
Branches 668 668
=======================================
Hits 2996 2996
Misses 33 33
Partials 1 1
Continue to review full report at Codecov.
|
|
||
rerender() | ||
simulateNativeClick(document.body) | ||
expect(handler2).toHaveBeenCalled() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handler1
should not be called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handler1
and handler2
should be called once each in this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion is mainly ensure handler2
has been called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
Thanks for your contribution, if you have no other changes we can just merge? |
Just merge, no patch version is needed, thx. |
Checklist
Change information
handler
should be updated if changed.Event
withMouseEvent