Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the infinite flashing issue, and merged with v0.5.0: Mandatory Height Calibration Prompt, Compatibility with Relay Server v1.1.0, Enhanced People Panel, Various Refactors #88

Merged
merged 33 commits into from
Nov 18, 2021

Conversation

Barasakar
Copy link
Contributor

@Barasakar Barasakar commented Nov 15, 2021

Fixed the infinite loop issue related to the visibility icon and merged the change to dev and main branches

Because of some early branching issues, v0.5.0 was built on a branch with infinite flashing bug for the visibility icon and models in Interact menu. This pull request addressed the bug and cleared up the branches.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Testing
  • Change that requires a documentation update

How Has This Been Tested?

Action to Take:
Build the project and run it on Komodo server.

Expected Result:
Clicking visibility icon for one of the models in Interact Menu should not cause the model or icon to flash infinitely.

  • Manual Test
  • Unit Test
  • Integration / End-to-End Test

Test Configuration:
Browser: Chrome/Firefox

  • PC VR (Link / AirLink)
  • Standalone

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas that are not self-documenting
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes have no unnecessary logging
  • I have added tests that prove my fix is effective or that my feature works, for sufficiently complex features
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Sensitive info like tokens, secrets, and passwords have been removed before submitting

Modified from this article:
Phillip Johnston, “A GitHub Pull Request Template for Your Projects - Embedded Artistry,” Embedded Artistry, Aug. 04, 2017. https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ (accessed Jul. 22, 2021).

barasakar and others added 30 commits October 20, 2021 14:50
@parseccentric
Copy link
Contributor

parseccentric commented Nov 18, 2021

Please see #85 for more information.

ExhibitionDome environment, Lighting tweaks

New Features

  • ExhibitionDome, based on FashionCritiqueSP21, is a new environment that replaces Outdoors.

Bug Fixes

  • Lock and visibility buttons are no longer prone to getting stuck in an infinitely alternating loop.
    • How to test: rapidly press the lock or visibility button for a model. It quickly stop changing states after you release the mouse button.
  • Load-time imported models now spawn above the ground rather than in it.

Tweaks

  • Lighting is now more neutral, rather than a yellow-ish hue.
  • A new reflection probe increases realism for reflective objects.

@parseccentric parseccentric marked this pull request as ready for review November 18, 2021 00:48
@parseccentric parseccentric merged commit 721c13b into main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants