Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.4-revA: Build Templates and Version Number #89

Merged
merged 2 commits into from
Nov 18, 2021
Merged

v0.5.4-revA: Build Templates and Version Number #89

merged 2 commits into from
Nov 18, 2021

Conversation

parseccentric
Copy link
Contributor

@parseccentric parseccentric commented Nov 18, 2021

v0.5.4-revA: Build Templates

Update build test template so that it's easier to edit.

Also updated package.json so OpenUPM has the correct version number.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Testing
  • Change that requires a documentation update

How Has This Been Tested?

N/A

Test Configuration:

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas that are not self-documenting
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes have no unnecessary logging
  • I have added tests that prove my fix is effective or that my feature works, for sufficiently complex features
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Sensitive info like tokens, secrets, and passwords have been removed before submitting

Modified from this article:
Phillip Johnston, “A GitHub Pull Request Template for Your Projects - Embedded Artistry,” Embedded Artistry, Aug. 04, 2017. https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ (accessed Jul. 22, 2021).

@parseccentric parseccentric changed the title v0.5.4-revA: Build Templates v0.5.4-revA: Build Templates and Version Number Nov 18, 2021
@parseccentric
Copy link
Contributor Author

@Barasakar or @ho-yi-shiuan, could one of you review this when you have a chance and do "Merge pull request"? Thanks!

@Barasakar
Copy link
Contributor

Everything looks good. I will merge the pull request and close it now. Thank you guys!

@Barasakar Barasakar merged commit 22dc765 into main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants