Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-markdown
is being used for the help system but it fails in production.After chasing down this issue, my conclusion is that
vite/rollup
has some troubles with modules using commonjs style rather than es stylevitejs/vite#2862
This is still odd because it works properly if I use it on the plain js side, thus there is something odd on the way scala.js interacts with commonjs imports
The solution I found is kind of convoluted but seems to work:
Remove the
react-markdown
dependency and internalize the.js
files fromreact-markdown
but convert them to es via cjstoesemThis feels very hacky but the only alternative I can think of is to reimplement in scala.
I'd like to at least test this in prod.