Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Rearrangement Algorithm Implementation (#1473) #11

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

vinsibal
Copy link

  • Rearrangement Algorithm Implementation

  • day layout algorithm as strategy pattern

  • day layout algorithm css customizable

& move Event class into overlap algorithm

  • restore yarn.lock

Additional updates:

  1. DayEventLayout.test.js to include testing the no-overlap algorithm.
  2. Changed the no-overlap calculation of width and height back to being able to be set by userProps
  3. Change the overlap alogrithm calc of width back to the original to not multiple by 1.7 which caused the unit tests to fail

* Rearrangement Algorithm Implementation

* day layout algorithm as strategy pattern

* day layout algorithm css customizable

& move Event class into overlap algorithm

* restore yarn.lock
@@ -1,200 +1,35 @@
import sortBy from 'lodash/sortBy'
/*eslint no-unused-vars: "off"*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you add _ at the beginning of the variable, it would not complain

@MSYuanMei MSYuanMei merged commit 8f232d6 into master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants