Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in go-edit.obo #27880

Merged
merged 1 commit into from
May 9, 2024
Merged

Fix typos in go-edit.obo #27880

merged 1 commit into from
May 9, 2024

Conversation

cmdcolin
Copy link
Contributor

@cmdcolin cmdcolin commented May 9, 2024

This follows some similar work that I started in other ontology repos to correct typos. This PR used the typos-cli tool https://crates.io/crates/typos-cli which has a pretty good low false positive rate. It is customized for source code typo checking but worked reasonably well here. I created a 'ignore list' containing false positives on gene names for instance, and then ran the typos correction script (write-changes)

similar PR on MONDO ontology
monarch-initiative/mondo#7685

pretty minor typos overall, but sort of a largish list of fixes

I focused on go-edit.obo because in mondo it was mondo-edit.obo that was noted to focus on

Copy link
Member

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @cmdcolin!

@balhoff
Copy link
Member

balhoff commented May 9, 2024

I noticed it missed onotolgy in a few places. I guess it doesn't know ontology?

@balhoff balhoff closed this May 9, 2024
@balhoff balhoff reopened this May 9, 2024
@balhoff
Copy link
Member

balhoff commented May 9, 2024

Closed and reopened so that QC checks run properly.

@cmdcolin
Copy link
Contributor Author

cmdcolin commented May 9, 2024

the typos-cli tool is a little interesting compared to "other spellcheckers" where they actually maintain a large list of manual corrections. this means there are definitely things that can be missed, but you can propose new fixes to them :) crate-ci/typos#1007

there are probably other spellcheckers that could be used that might work more like a 'edit distance to other word' that could be used also, but i haven't tried those yet

@balhoff
Copy link
Member

balhoff commented May 9, 2024

The checks still aren't running properly, due to this issue: https://github.com/orgs/community/discussions/44322

I'll merge and take responsibility for fixing any problems that sneak in.

@balhoff balhoff merged commit ebf1a20 into geneontology:master May 9, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants