Merge master to master-vs-deps #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drawbacks: * Only covers cases where the invocation is nested within an executable statement * Performs abysmally due to creating a whole speculative semantic model for the vast majority of invocations, and additionally using GetOperation which is quite slow in general At some point amongst all the code that runs there is presumably a crucial function which has the rules for binding a name-type syntax into an invocation. Ideally we'd find a way to call just that function here on invocationExpression.Expression
(even without an arg list) It's possible there are some other cases when VB will happily invoke something without an arg list, but since i can't find the relevant spec or code, I'm erring on the side of caution
…ionTests.vb Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
Therefore we can't know it's safe to remove parentheses since it could be a delegate
This is to allow "TestInsertCallIfNecessary3()" to continue to pass. Note that the test result isn't fully simplified since it says: Call (Sub() Exit Sub) instead of Call Sub() Exit Sub This is outside the scope of this PR
There is no parameterless Console.Write hence it doesn't resolve, and Program doesn't exist in the context at all Don't think it's worth considering CandidateSymbols since they won't always be correct Expanding and reducing stuff that doesn't compile sounds generally risky. In a future PR perhaps the expander shouldn't add the parentheses if it can't resolve the symbol.
If it wasn't invokable it wouldn't be valid at this point
This reverts commit 3787058.
…rmed" XML comments contain superfluous /// markers for every line-break in the original comment.
…clarationNameCompletionProvider.NameGenerator.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…king if the first character is a digit.
…clarationNameCompletionProvider.NameGenerator.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
…ocument.GetLanguageService<ISyntaxFactsService>().
… the identifier escaping for keywords.
Change Roslyn to target netcoreapp3.1 when building .NET Core assets. Previously the code targetted a mix of netcoreapp2.1 and netcoreapp3.0. The mix is due to default interfaces only being supported on netcoreapp3.0 and hence our testing needed to use that. Yet at the same time we were required to ship the compiler in SDKS that targetted netcoreapp2.1. Now we can universally target netcoreapp3.1.
Decided to remove the property based approach to specifying a target framework to just specifying `netcoreapp3.1` directly. The reason for this is the following: The advantage of the property is it makes it "easy" to change to a new target framework in the future. That benefit is actually pretty minimal. A simple find and replace operation is **extremely** effective in our code base (it's less key strokes than this message). Hence the benefit is minimal. The downside of the property is that our code doesn't look like customer code. Or rather it diverges from the practices that we publish. In general I prefer to keep our code as standard as possible unless there is a good reason to deviate. There just doesn't seem to be one here.
Had to clean up a few nullable annotations now that we are compiling agaist `netcoreapp3.1` and hence get the full value of the framework annotations. This is also problematic though because there are now two places where the compiler can see nullable attributes that are directly used by the developer. For example `NotNullWhenAttribute`. This is both defined in our assemblies for non-netcoreapp target frameworks and provided by the SDK when targeting `netcoreapp3.1`. This causes a problem for assemblies which have the following characteristics: 1. Target `netcoreapp3.1` 1. Reference an assembly targeting `netstandard2.0` which uses our nullable attributes definition 1. Has IVT into (2) above These properties essentially define all of our unit test assemblies. In that environment it's not possible to use nullable attributes in code because the compiler can't disambiguate which definition of `NotNullWhenAttribute` to use. This meant I had to temporarily remove a few attributes until we can complete dotnet#40766.
* Update dependencies from https://github.com/dotnet/arcade build 20200129.8 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20079.8 * Update dependencies from https://github.com/dotnet/arcade build 20200130.4 - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20080.4
Name suggestions don't contain suggestions starting with a digit.
Target netcoreapp3.1
Make ValueText return empty instead of null
Fix issues in MetadataAsSource XML documentation comment conversion
* Fix Pythia pooled objects wrappers * Fix RPC
Fix for Visual Studio crashes when adding a parameter to a function
…mplification-arglist Stop Simplifier.ReduceAsync removing empty arg lists from delegates
genlu
pushed a commit
that referenced
this pull request
Apr 3, 2020
Add ExternalAccess.Razor shims for newly added DocumentPropertiesService APIs.
genlu
pushed a commit
that referenced
this pull request
Jun 9, 2021
…ayer Simplify migration from EditorFeatures to Features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into master-vs-deps.
(created from a manual run of the PR generation tool)
git fetch --all git checkout merges/master-to-master-vs-deps git reset --hard upstream/master-vs-deps git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-master-vs-deps --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.