new gcs evaluator - attempt at fixing performance issue introduced via gcsl rework #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srliao
force-pushed
the
srl-2023-09-01-new-gcs-eval
branch
2 times, most recently
from
71615ed to
c6e2e91
Compare
srliao
force-pushed
the
srl-2023-09-01-new-gcs-eval
branch
2 times, most recently
from
e53a9dc to
a04da22
Compare
srliao
force-pushed
the
srl-2023-09-01-new-gcs-eval
branch
from
37e9b66 to
1508108
Compare
srliao
force-pushed
the
srl-2023-09-01-new-gcs-eval
branch
from
1508108 to
8703392
Compare
- handle user fn calls - fix blockstmt stack handling - add execute_action
srliao
force-pushed
the
srl-2023-09-01-new-gcs-eval
branch
from
8703392 to
141c91f
Compare
k0l11
added
kind: enhancement
add experimental is_target_dead sys func
|
on hold for now because it looks like this might actually be a performance decrease for wasm. needs more testing also need to fix env scoping which is causing issues with closures not behaving properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the gcs evaluator to remove the use of channel for blocking purposes (not truly a concurrent workload) which adds a lot of overhead as a result of context switching