Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust xiangling a4 to not automatically trigger #1708

Merged
merged 1 commit into from
Sep 17, 2023
Merged

adjust xiangling a4 to not automatically trigger #1708

merged 1 commit into from
Sep 17, 2023

Conversation

k0l11
Copy link
Collaborator

@k0l11 k0l11 commented Sep 15, 2023

closes #1707

  • < 0 means no a4
  • default: 0 -> -1

@k0l11
adjust xiangling a4 to not automatically trigger
15d6805 
- < 0 means no a4
- default: 0 -> -1
@k0l11 k0l11 added area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game labels Sep 15, 2023
@k0l11 k0l11 marked this pull request as ready for review September 15, 2023 19:11
@k0l11 k0l11 merged commit 96179ae into genshinsim:main Sep 17, 2023
3 checks passed
@k0l11 k0l11 deleted the xl-a4 branch September 17, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imring imring imring approved these changes

Assignees
No one assigned
Labels
area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xiangling a4 should not always be picked up
2 participants
@k0l11 @imring