Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kazuha q snapshot timing #1710

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix kazuha q snapshot timing #1710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions internal/characters/kazuha/burst.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func (c *char) Burst(p map[string]int) action.Info {
}
ap := combat.NewCircleHitOnTarget(player, geometry.Point{Y: 1}, 9)

c.Core.QueueAttack(ai, ap, 0, burstHitmark)
c.Core.QueueAttack(ai, ap, burstHitmark, burstHitmark)

// apply dot and check for absorb
ai.Abil = "Kazuha Slash (Dot)"
Expand All @@ -56,19 +56,21 @@ func (c *char) Burst(p map[string]int) action.Info {
ai.Durability = 25
// no more hitlag after initial slash
ai.HitlagHaltFrames = 0
snap := c.Snapshot(&ai)

aiAbsorb := ai
aiAbsorb.Abil = "Kazuha Slash (Absorb Dot)"
aiAbsorb.Mult = burstEleDot[c.TalentLvlBurst()]
aiAbsorb.Element = attributes.NoElement
snapAbsorb := c.Snapshot(&aiAbsorb)

c.Core.Tasks.Add(c.absorbCheckQ(c.Core.F, 0, int(310/18)), 10)

// handle C2
// first tick is right before initial hit, ticks every 0.5s while burst is up
c.QueueCharTask(func() {
// snapshot ticks right before slash
c.qTickSnap = c.Snapshot(&ai)
c.qTickAbsorbSnap = c.Snapshot(&aiAbsorb)

c.Core.Status.Add(burstStatus, (burstFirstTick-(burstHitmark-1))+117*4)
if c.Base.Cons >= 2 {
c.qFieldSrc = c.Core.F
Expand All @@ -87,9 +89,9 @@ func (c *char) Burst(p map[string]int) action.Info {
c.Core.Tasks.Add(func() {
if c.qAbsorb != attributes.NoElement {
aiAbsorb.Element = c.qAbsorb
c.Core.QueueAttackWithSnap(aiAbsorb, snapAbsorb, ap, 0)
c.Core.QueueAttackWithSnap(aiAbsorb, c.qTickAbsorbSnap, ap, 0)
}
c.Core.QueueAttackWithSnap(ai, snap, ap, 0)
c.Core.QueueAttackWithSnap(ai, c.qTickSnap, ap, 0)
}, (burstFirstTick-(burstHitmark+1))+117*i)
}
// C6:
Expand Down
2 changes: 2 additions & 0 deletions internal/characters/kazuha/kazuha.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ type char struct {
qAbsorb attributes.Element
qFieldSrc int
qAbsorbCheckLocation combat.AttackPattern
qTickSnap combat.Snapshot
qTickAbsorbSnap combat.Snapshot
c2buff []float64
}

Expand Down