-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor char actions to return error #1720
Merged
srliao
merged 77 commits into
genshinsim:main
from
srliao:srl-2023-09-22-unimplemented-checks
Sep 23, 2023
Merged
refactor char actions to return error #1720
srliao
merged 77 commits into
genshinsim:main
from
srliao:srl-2023-09-22-unimplemented-checks
Sep 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
srliao
commented
Sep 23, 2023
- allow char actions to properly return error if needed (instead of currently panicking in the rare case)
- add automate test to use each ability once for each char to catch unexpected panics
- add default "implementation" for all actions to template to avoid stack overflow and give proper error msg
- fixed a wanderer bug that got caught coincidentally....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.