Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sigewinne #2253

Merged
merged 9 commits into from
Oct 26, 2024
Merged

add sigewinne #2253

merged 9 commits into from
Oct 26, 2024

Conversation

ange1o5
Copy link
Contributor

@ange1o5 ange1o5 commented Oct 24, 2024 •
edited by imring
Loading

  • New character package
  • Config in character package
  • Run pipeline with added config (generates character curve, talent stats, .generated.json files)
  • Character key
  • Shortcuts for character key
  • Update mode_gcsim.js with shortcuts for syntax highlighting
  • Add Character package to imports
  • Normal Attack
  • Charge Attack / Aimed Shot
  • Skill
  • Burst
  • A1
  • A4
  • C1
  • C2
  • C3
  • C4
  • C5
  • C6
  • Other necessary talents (custom dash/jump, low/high plunge, ...)
  • Hitlag
  • ICD
  • StrikeType
  • PoiseDMG (blunt attacks only for now)
  • Hitboxes
  • Attack durability
  • Particles
  • Frames
  • Update documentation
  • Xingqiu/Yelan N0 (optional)
  • Xianyun Plunge (optional)

@imring imring added area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game labels Oct 24, 2024
@ange1o5
Copy link
Contributor Author

ange1o5 commented Oct 24, 2024

To fix:

  • fix run tests
  • energy on BoL clear
  • check if a1 works
  • heal ticks
  • healing bonus bubble tier
  • healing bonus BoL

@imring imring merged commit 91a107d into genshinsim:main Oct 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imring imring imring approved these changes

Assignees
No one assigned
Labels
area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ange1o5 @imring