Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add calamity of eshu #2268

Merged
merged 2 commits into from
Nov 22, 2024
Merged

add calamity of eshu #2268

merged 2 commits into from
Nov 22, 2024

Conversation

kengzzzz
Copy link
Contributor

@kengzzzz kengzzzz commented Nov 15, 2024 •
edited
Loading

  • New weapon package
  • Config in weapon package
  • Run pipeline with added config (generates weapon curve, .generated.json files)
  • Weapon key
  • Shortcuts for weapon key
  • Add weapon package to imports
  • Weapon passive (might include an attack)
  • Update documentation

@imring imring added area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game labels Nov 16, 2024
@kengzzzz kengzzzz marked this pull request as ready for review November 18, 2024 11:40
@shizukayuki shizukayuki merged commit 88117b6 into genshinsim:main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: internal Related to artifacts/weapons/characters kind: game alignment Missing mechanic from the game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kengzzzz @imring @shizukayuki