fix gcs test and add to workflow

.github/actions/go-setup-and-test/action.yml

@@ -3,12 +3,12 @@ description: "runs setup-go and runs all unit tests in the repo"
 runs:
   using: composite
   steps:
-  - uses: actions/setup-go@v3
-    with:
-      go-version: "^1.19.3"
-  - name: Run Tests
-    working-directory: ./
-    shell: bash
-    run: "go test ./internal/..."
-    # should run below, need to fix existing tests
-    # run: "go test ./backend/... ./internal/... ./pkg/..."
+    - uses: actions/setup-go@v3
+      with:
+        go-version: "^1.21"
+    - name: Run Tests
+      working-directory: ./
+      shell: bash
+      run: "go test ./internal/... ./pkg/gcs/..."
+      # should run below, need to fix existing tests
+      # run: "go test ./backend/... ./internal/... ./pkg/..."

pkg/gcs/eval_fn_test.go

@@ -36,6 +36,7 @@ func TestFib(t *testing.T) {
 		resultChan <- res
 	}()
 	for {
+		eval.Continue()
 		a, err := eval.NextAction()
 		if a == nil {
 			break
@@ -90,6 +91,7 @@ func TestFunctional(t *testing.T) {
 		resultChan <- res
 	}()
 	for {
+		eval.Continue()
 		a, err := eval.NextAction()
 		if a == nil {
 			break
@@ -137,6 +139,7 @@ func TestAnonFunc(t *testing.T) {
 		resultChan <- res
 	}()
 	for {
+		eval.Continue()
 		a, err := eval.NextAction()
 		if a == nil {
 			break
@@ -184,6 +187,7 @@ func TestStringFunc(t *testing.T) {
 		resultChan <- res
 	}()
 	for {
+		eval.Continue()
 		a, err := eval.NextAction()
 		if a == nil {
 			break
@@ -214,7 +218,7 @@ func TestStringFunc(t *testing.T) {
 func TestNestedActions(t *testing.T) {
 	prog := `
 	fn do() {
-		xingqiu attack;
+		print("hi");
 	}
 	do();
 	`
@@ -231,9 +235,13 @@ func TestNestedActions(t *testing.T) {
 	go func() {
 		res, err := eval.Run()
 		fmt.Printf("done with result: %v, err: %v\n", res, err)
+		if err != nil {
+			log.Fatalf("test run failed with error: %v", err)
+		}
 		resultChan <- res
 	}()
 	for {
+		eval.Continue()
 		a, err := eval.NextAction()
 		if a == nil {
 			break
@@ -243,8 +251,9 @@ func TestNestedActions(t *testing.T) {
 		}
 	}
 	result := <-resultChan
-	if result.Typ() != typNull {
-		t.Errorf("expecting type to return null, got %v", typStrings[result.Typ()])
+	// by default, functions return num
+	if result.Typ() != typNum {
+		t.Errorf("expecting type to return num, got %v", typStrings[result.Typ()])
 	}
 	if eval.Err() != nil {
 		t.Error(eval.Err())

pkg/gcs/eval_test.go

@@ -24,6 +24,7 @@ func TestType(t *testing.T) {
 		resultChan <- res
 	}()
 	for {
+		eval.Continue()
 		a, err := eval.NextAction()
 		if a == nil {
 			break
@@ -43,7 +44,10 @@ func TestType(t *testing.T) {
 
 func TestForceTerminate(t *testing.T) {
 	// test terminate eval early should gracefully exit
-	p := ast.New("xingqiu attack:50;")
+	p := ast.New(`
+	for let i = 0; i < 50; i = i + 1 {
+		delay(1);
+	}`)
 	_, gcsl, err := p.Parse()
 	if err != nil {
 		t.Fatal(err)
@@ -101,6 +105,7 @@ func TestSleepAsWaitAlias(t *testing.T) {
 		res, err := eval.Run()
 		fmt.Printf("done with result: %v, err: %v\n", res, err)
 	}()
+	eval.Continue()
 	a, err := eval.NextAction()
 	if err != nil {
 		t.Errorf("unexpected error getting next action: %v", err)
@@ -124,7 +129,10 @@ func TestSleepAsWaitAlias(t *testing.T) {
 
 func TestDoneCheck(t *testing.T) {
 	// eval should exit once out of action; NextAction() should return nil
-	p := ast.New("xingqiu attack, attack, skill, burst;")
+	p := ast.New(`
+	for let i = 0; i < 4; i = i + 1 {
+		delay(1);
+	}`)
 	_, gcsl, err := p.Parse()
 	if err != nil {
 		t.Fatal(err)