Enhancement: equery m maps the remote-id to the respective url. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
reviewed
Sep 19, 2023
pym/gentoolkit/equery/meta.py
Outdated
| @@ -189,10 +189,43 @@ def _format_upstream_docs(docs): | |||
|
|
|||
| def _format_upstream_ids(ids): | |||
| result = [] | |||
| sites = { | |||
There was a problem hiding this comment.
Suggested change
| sites = { | |
| remote_ids = { |
There was a problem hiding this comment.
or maybe: remote_id_map? not sure
There was a problem hiding this comment.
remote_ids was available so went with that although there's one more var remoteids.. should I change it to remote_id_map ?
Bug: https://bugs.gentoo.org/877519 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com>
thesamesam
approved these changes
Sep 19, 2023
|
Nice job! |
hyprsyd
added a commit
to hyprsyd/gentoolkit
that referenced
this pull request
Oct 9, 2023
Bug: https://bugs.gentoo.org/877519 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: gentoo#32 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://bugs.gentoo.org/877519