-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress invalid binary error from portage #35
Conversation
pym/gentoolkit/eclean/search.py
Outdated
@@ -573,7 +573,7 @@ def findPackages( | |||
settings = var_dbapi.settings | |||
bin_dbapi = portage.binarytree(pkgdir=pkgdir, settings=settings).dbapi | |||
if "force_reindex" in signature(bin_dbapi.bintree.populate).parameters: | |||
bin_dbapi.bintree.populate(force_reindex=True) | |||
bin_dbapi.bintree.populate(force_reindex=True, invalid_errors=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could test if invalid_errors is supports, like:
pop_sig_params = signature(bin_dbapi.bintree.populate).parameters
populate_kwargs = {}
if "invalid_errors" in pop_sig_params:
populate_kwargs["invalid_errors"] = False
bin_dbapi.bintree.populate(force_reindex=True, **populate_kwargs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zmedico I forgot again :-(
f5843fc
to
193f3cd
Compare
Last implemention was importing binhost module incorectly. Calling Modules() from portage.module which sets binhost var to the BinhostHandler class would always fail as it needs name and namepath leading to always call emaint via a subprocess call. Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com>
Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Introduce 'invalid_errors' var to enable suppression of invalid binary error, for use by gentoolkit. [sam: See gentoolkit side at gentoo/gentoolkit#35]. Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: #1123 Signed-off-by: Sam James <sam@gentoo.org>
[sam: Note that this needs gentoo/portage#1123 on the Portage side.] Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: gentoo#35 Signed-off-by: Sam James <sam@gentoo.org>
Introduce 'invalid_errors' var to enable suppression of invalid binary error, for use by gentoolkit. [sam: See gentoolkit side at gentoo/gentoolkit#35]. Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: gentoo#1123 Signed-off-by: Sam James <sam@gentoo.org>
Introduce 'invalid_errors' var to enable suppression of invalid binary error, for use by gentoolkit. [sam: See gentoolkit side at gentoo/gentoolkit#35]. Bug: https://bugs.gentoo.org/900224 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: gentoo#1123 Signed-off-by: Sam James <sam@gentoo.org>
Fix pkgindex.py and Suppress invalid binary error from portage.
see also: gentoo/portage#1123