Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save-build-env: Strip out MAKEOPTS #1311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Commits on Apr 24, 2024

  1. save-build-env: Strip out MAKEOPTS and NINJAOPTS

    MAKEOPTS and NINJAOPTS contains a host specific value. If the same
    package is built on a host with different core counts, the binpkgs will
    have different hashes. This change drops MAKEOPTS after src_install so
    that it's not included in final environment.gz. This change also adds
    them to the special_env_vars.py so that we always have the most up to
    date version of these variables.
    
    Bug: https://bugs.gentoo.org/914441
    Bug: https://bugs.gentoo.org/736794
    Signed-off-by: Raul E Rangel <rrangel@chromium.org>
    Raul E Rangel committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4715ed3 View commit details
    Browse the repository at this point in the history
  2. save-build-env: Strip out non-reproducible variables

    Bash provides access to the time and a random data via variables. We
    don't want to persist these values when generating a binpkg.
    
    Bug: https://bugs.gentoo.org/914441
    Signed-off-by: Raul E Rangel <rrangel@chromium.org>
    Raul E Rangel committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    745a4df View commit details
    Browse the repository at this point in the history