Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: add a 5 second timeout to gemato's openpgp refresh #1374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Aug 27, 2024

  1. sync: add a 5 second timeout to gemato's openpgp refresh

    If it takes more than 5 seconds to download a miniscule file from
    https://gentoo.org/.well-known/openpgpkey/ then something has gone
    dreadfully wrong. Most commonly, what went wrong is that the user has
    broken ipv6 connectivity and requests simply hangs forever (no joke --
    it doesn't implement Happy Eyeballs and closed the multiple bug reports
    as "please use stackoverflow to ask questions about how to use requests,
    we are not a support forum").
    
    Pass a timeout so that we eventually give up and try ipv4 instead. This
    is a crude hack and the proper solution is to make gemato handle this
    better, but until gemato is fixed to use a better download library we do
    the best we can.
    
    Bug: psf/requests#6788
    Bug: projg2/gemato#35
    Bug: https://bugs.gentoo.org/779766
    Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
    eli-schwartz committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    47ad402 View commit details
    Browse the repository at this point in the history