install_qa_check: Fix noclean interaction with merge-wait #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floppym
approved these changes
Nov 4, 2024
bin/misc-functions.sh
Outdated
Comment on lines
262
to
263
| if has merge-wait ${FEATURES} && \ | ||
| ! has keepwork ${FEATURES} && \ |
There was a problem hiding this comment.
The newline escapes are unnecessary when && appears as the last word on the line.
Fixes: 8ac72ee ("install_qa_check: prematurely delete WORKDIR if FEATURES=merge-wait") Bug: https://bugs.gentoo.org/942760 Signed-off-by: Zac Medico <zmedico@gentoo.org>
zmedico
force-pushed
the
bug_942760_fix_noclean_interaction_with_merge-wait
branch
from
310598b
to
6648a0d
Compare
zmedico
deleted the
bug_942760_fix_noclean_interaction_with_merge-wait
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 8ac72ee ("install_qa_check: prematurely delete WORKDIR if FEATURES=merge-wait")
Bug: https://bugs.gentoo.org/942760