-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reflection mechanism and alembic interactions #374
Improve reflection mechanism and alembic interactions #374
Conversation
251adf0
to
be6b69e
Compare
52cc395
to
297d6ce
Compare
The _column_flag attribute is used to skip index creation in the to_metadata() method.
9a2db94
to
58de466
Compare
58de466
to
84bb0d0
Compare
Hi @zzzeek |
the before/after create dispatch was added to support some ENUM use cases which relied upon these to create their constraints. it looks like the current scope of before/after create/drop is limited to just MetaData and Table in SQLAlchemy (like, not for constraints or anything like that) so sure if you want to send a PR w/ tests for the drop events, that's fine, look right here: |
15825b6
to
75dfba9
Compare
1c9fd41
to
219f259
Compare
80f201f
to
5deed2a
Compare
Goals of this PR:
spatial_index=True
) and compatible with all SQLAlchemy mechanisms and with Alembic.Main issues:
_column_flag=True
makes it work withto_metadata
but it's a private attribute so it might not be reliable?before_create
andafter_create
events but not thebefore_drop
andafter_drop
events on which we rely on.