Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intro tweaks2 #984

Merged
merged 12 commits into from
Sep 8, 2023
Merged

intro tweaks2 #984

merged 12 commits into from
Sep 8, 2023

Conversation

Robinlovelace
Copy link
Collaborator

  • Tweak intro
  • Shorten intro
  • Explain advantages of getting started with R
  • More prose refactoring

@Robinlovelace
Copy link
Collaborator Author

r-tmap/tmap#768 causing the build to fail I think. Happy to wait until it's fixed as it will break the workflows.

@Robinlovelace
Copy link
Collaborator Author

Heads-up guys I think this is good to go. Fairly non-controversial and some improvements in there I think. Review pre or post merge welcome, let's hope actions pass!

@Robinlovelace Robinlovelace merged commit f4dfa8a into main Sep 8, 2023
3 checks passed
@Robinlovelace Robinlovelace deleted the intro-tweaks2 branch September 8, 2023 16:57
github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
* Tweak intro

* Shorten intro

* Explain advantages of getting started with R

* More prose refactoring

* Turn some things off, fix CI

See #985 and r-tmap/tmap#766

* Remove errant tmap_mode()

* Remove magick dependency

* Uncomment another line...

* Use ghcr for binder image

* Uncomment tmap-related lines

* Improve description of geocomp in other languages

* Add link to geocompy f4dfa8a
@Nowosad
Copy link
Member

Nowosad commented Sep 9, 2023

Nice improvements @Robinlovelace -- I just made a small cleaning to it (79416e6).

@Robinlovelace
Copy link
Collaborator Author

Thanks @Nowosad, I've just taken a look at the changes in 79416e6 and they are all spot on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants