Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not silence exceptions on custom plugins (#487) #527

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

tomkralidis
Copy link
Member

Overview

Emits repository exceptions to server logs for debugging.

Related Issue / Discussion

#487

Additional Information

None

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #527 into master will decrease coverage by 0.05%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
- Coverage   56.04%   55.99%   -0.06%     
==========================================
  Files          29       29              
  Lines        6320     6326       +6     
  Branches     1338     1338              
==========================================
  Hits         3542     3542              
- Misses       2400     2407       +7     
+ Partials      378      377       -1
Flag Coverage Δ
#integrationtests 54.64% <9.09%> (-0.06%) ⬇️
#unittests 7.6% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pycsw/server.py 65.41% <9.09%> (-0.83%) ⬇️
pycsw/ogc/fes/fes2.py 39.13% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17873ac...6d90141. Read the comment docs.

@tomkralidis tomkralidis merged commit ad0dddb into geopython:master Jun 7, 2017
@tomkralidis tomkralidis deleted the issue-487 branch June 7, 2017 16:25
minhd added a commit to minhd/pycsw that referenced this pull request Jun 9, 2017
* master:
  Do not silence exceptions on custom plugins (geopython#487) (geopython#527)
  decouple requirements files in lieu of assembling via tox config (geopython#521) (geopython#497)
  from mock import Mock as MagicMock
  codecov integration (geopython#525)
  fixed code review issues
  version is now stored on a single file, VERSION.txt
  removed python 2.6 from the tox settings
  fix ref (geopython#514)
  Fixed harvesting WMS. calling undefined function (geopython#518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant