force CI to build and tag on branch name (#3501) #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmauduit @fvanderbiest could you make the review ? |
pmauduit
approved these changes
Mar 28, 2023
I have no objection regarding this PR, but I wonder what do we want/need exactly, in term of build/push onto docker-hub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix georchestra/georchestra#3501
CI was not creating tagged images probably because it relied on git tags rather than branches
should work for both now.
Also includes some (harmless?) modifications of variables of the CI,
GITHUB_REF_NAME,VERSION(which was equal togithub.ref_name)same PR to come on
mapstore2-georchestra/2022.02.xxbranch