Add appropriate alert message when trying to add by hostname on linux

georg-jung · Dec 13, 2019 · 6293efb · 6293efb
1 parent 48a1501
commit 6293efb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/WoL/Pages/AddHost.razor b/WoL/Pages/AddHost.razor
@@ -115,9 +115,16 @@
         {
             host = await GetHost();
         }
+        catch (DllNotFoundException ex)
+        {
+            L.LogInformation(ex, $"DllNotFound during name resolution or determination of mac address. Page: {nameof(AddHost)}");
+            Alert = "This operation is not supported on the operating system this application is running on. Adding hosts by hostname is currently not supported on linux due to the lack of an apropriate ARP API.";
+            Creating = false;
+            return;
+        }
         catch (Exception ex)
         {
-            L.LogInformation(ex, $"Exception during name resolution or determination of mac address. Page: {nameof(AddHost)}");
+            L.LogDebug(ex, $"Exception during name resolution or determination of mac address. Page: {nameof(AddHost)}");
             Alert = "This hostname or it's mac address could not be found.";
             Creating = false;
             return;

diff --git a/WoL/Services/DnsPingServiceBase.cs b/WoL/Services/DnsPingServiceBase.cs
@@ -32,7 +32,7 @@ public DnsPingServiceBase(IAddressLookupService addressLookupService, ILogger lo
             catch (Exception ex)
 #pragma warning restore CA1031 // Keine allgemeinen Ausnahmetypen abfangen
             {
-                logger.LogInformation(ex, $"Exception during {nameof(IAddressLookupService)}.{nameof(IAddressLookupService.GetIpAndName)}");
+                logger.LogDebug(ex, $"Exception during {nameof(IAddressLookupService)}.{nameof(IAddressLookupService.GetIpAndName)}");
                 return PingResult.HostNotFound;
             }
             return await IsReachable(ip, timeout).ConfigureAwait(false) ? PingResult.Success : PingResult.Unreachable;