fix warnings/code smells

georg-jung · May 19, 2020 · d54629d · d54629d
1 parent 4900a51
commit d54629d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/WoL/Data/HostService.cs b/WoL/Data/HostService.cs
@@ -68,7 +68,7 @@ public async Task Delete(int id)
 
         public async Task<Host> Find(int id)
         {
-            return await context.Hosts.FindAsync(id);
+            return await context.Hosts.FindAsync(id).ConfigureAwait(false);
         }
     }
 }
diff --git a/WoL/Extensions/StringExtensions.cs b/WoL/Extensions/StringExtensions.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using System.Threading.Tasks;
 
@@ -9,7 +10,7 @@ public static class StringExtensions
     {
         public static byte[] ParseMacAddress(this string mac)
         {
-            var macString = mac?.Replace(":", "-", StringComparison.Ordinal)?.ToUpper() ?? throw new ArgumentNullException(nameof(mac));
+            var macString = mac?.Replace(":", "-", StringComparison.Ordinal)?.ToUpper(CultureInfo.InvariantCulture) ?? throw new ArgumentNullException(nameof(mac));
             return System.Net.NetworkInformation.PhysicalAddress.Parse(macString).GetAddressBytes();
         }
 

diff --git a/WoL/Services/CompositePingService.cs b/WoL/Services/CompositePingService.cs
@@ -18,7 +18,7 @@ public CompositePingService(IAddressLookupService addressLookupService, RdpPortP
             this.icmpPing = icmpPing;
         }
 
-        public async override Task<bool> IsReachable(IPAddress ip, TimeSpan timeout)
+        public override async Task<bool> IsReachable(IPAddress ip, TimeSpan timeout)
         {
             // start pings in parallel
             var rdp = rdpPing.IsReachable(ip, timeout);