Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column matching for function pipelining #1417

Open
wants to merge 15 commits into
base: staging
Choose a base branch
from

Conversation

Y1feiwang
Copy link

@Y1feiwang Y1feiwang commented Nov 25, 2023

matches custom function's expected name with the actual input name through first matching name, then shape of the data in the column, and at last type. All change are made in evadb/models/storage/batch.py.

@Y1feiwang Y1feiwang marked this pull request as ready for review November 25, 2023 23:53
@xzdandy
Copy link
Collaborator

xzdandy commented Dec 2, 2023

Hi, I think this PR does not merge correctly with staging. It reverts mange changes on the staging branch. We need to fix the merge errors. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants