-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pre-commit and some formatting #1449
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @lnxpy, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify that your PR is up-to-date with
georgia-tech-db/eva
master
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge master
locally. - ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.
I think this CI message needs an update too. The default branch is |
@lnxpy Thanks for the effort, let me fix the build and then merge your PR. |
Hi @gaurav274! I'm working on #1348 as well so the contribution guideline will need a major update after that. |
This PR contains:
test/third_party_tests/*.db
(it gets generated whenever someone runs the tests)pre-commit
configurations (usingblack
andcheck-docstring-first
for better code quality insurance)We can specify which docstring convention should be checked while committing.
source/dev-guide/contribute.html
doc needs to be updated. I can work on them as well.This PR closes #1347