Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Transaction::dataset{,_mut} in favour of Deref{,Mut} #265

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Deprecate Transaction::dataset{,_mut} in favour of Deref{,Mut} #265

merged 1 commit into from
Jul 5, 2022

Conversation

ttencate
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

@rmanoka
Copy link
Contributor

rmanoka commented Jun 19, 2022 •
edited
Loading

@ttencate this looks great to me. We should however deprecate the existing APIs, and remove in the next release. Could you make that change? EdIt: also, it's not a breaking change if deprecating.

@lnicola any other blockers?

@ttencate ttencate force-pushed the feature/transaction_deref branch from 3bd87ec to c6e569b Compare July 5, 2022 07:04
@ttencate ttencate changed the title Remove Transaction::dataset{,_mut} in favour of Deref{,Mut} Deprecate Transaction::dataset{,_mut} in favour of Deref{,Mut} Jul 5, 2022
@ttencate
Copy link
Contributor Author

ttencate commented Jul 5, 2022

All done!

@lnicola
Copy link
Member

lnicola commented Jul 5, 2022

bors r=rmanoka,lnicola

@bors
Copy link
Contributor

bors bot commented Jul 5, 2022

Build succeeded:

@bors bors bot merged commit d640dd7 into georust:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttencate @rmanoka @lnicola