use tempfiles to not access file multiple times #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
reviewed
Sep 2, 2022
src/programs/raster/mdimtranslate.rs
Outdated
|
|
||
| impl TempDataset { | ||
| pub fn fixture(name: &str) -> Self { | ||
| let path = std::path::Path::new(file!()) |
There was a problem hiding this comment.
Is this really better than Path::new("fixtures")? The tests should run in the root directory of the project.
There was a problem hiding this comment.
I can revert that, just copied it from fixtures!
There was a problem hiding this comment.
|
Can we make a |
lnicola
approved these changes
Sep 2, 2022
2 tasks
|
bors merge |
|
Build succeeded: |
This was referenced Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.