Make raster index usize

[lnicola]

• I agree to follow the project's code of conduct.
• I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

---

[jdroenner]

I'm not against this change but i always worry that there is a hidden reason why it is an int and not an uint in C/C++...

[lnicola]

They're 1-based. I think it's just that int is the "default" data type in C.

nBandId the index number of the band to fetch, from 1 to GetRasterCount().

[lnicola]

r? @jdroenner again 😃.

[metasim]

If it wouldn't cause a riot, I'd suggest we change it to NonZeroUsize. But it does add a bunch of unwrap and try_into friction.

[lnicola]

Yeah, I've considered that, but it seems annoying. raster_count() would still return usize.

[metasim]

@jdroenner FWIW I'm in favor of approving and merging this.

[jdroenner]

i guess we need to resolve the changelog conflicts again

[lnicola]

bors r=metasim,jdroenner

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• ci gdal-3.1.3
• ci gdal-3.2.3
• ci gdal-3.3.3
• ci gdal-3.4.3
• ci gdal-3.5.3
• ci gdal-3.6.4
• ci gdal-3.7.0
• ci ubuntu-lts