-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/454 #455
Fix/454 #455
Conversation
`CslStringList::get_field`, `CslStringList::find_string`, `CslStringList::partial_find_string`, `CslStringList::find_string_case_sensitive`
Added documentation.
[skip ci]
Oh, this is great. I'll take a look tomorrow. |
Sanitizer results: https://github.com/metasim/gdal/actions/runs/6618106265/job/17975832725 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I left some nits (mostly).
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
bors r+ |
@lnicola thank you for the comprehensive PR review. Definitely made it better! |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
CHANGES.md
if knowledge of this change could be valuable to users.Closes #454