Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/454 #455

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Fix/454 #455

merged 6 commits into from
Oct 25, 2023

Conversation

metasim
Copy link
Contributor

@metasim metasim commented Oct 23, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Closes #454

`CslStringList::get_field`, `CslStringList::find_string`, `CslStringList::partial_find_string`, `CslStringList::find_string_case_sensitive`
Added documentation.
@metasim metasim requested review from lnicola and jdroenner October 23, 2023 19:26
[skip ci]
@lnicola
Copy link
Member

lnicola commented Oct 23, 2023

Oh, this is great. I'll take a look tomorrow.

@metasim
Copy link
Contributor Author

metasim commented Oct 23, 2023

src/cpl.rs Outdated Show resolved Hide resolved
src/cpl.rs Outdated Show resolved Hide resolved
src/cpl.rs Show resolved Hide resolved
src/cpl.rs Outdated Show resolved Hide resolved
src/cpl.rs Show resolved Hide resolved
src/cpl.rs Outdated Show resolved Hide resolved
src/cpl.rs Outdated Show resolved Hide resolved
src/cpl.rs Show resolved Hide resolved
src/cpl.rs Outdated Show resolved Hide resolved
src/cpl.rs Show resolved Hide resolved
src/cpl.rs Show resolved Hide resolved
src/cpl.rs Show resolved Hide resolved
Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I left some nits (mostly).

metasim and others added 3 commits October 24, 2023 14:26
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
@metasim
Copy link
Contributor Author

metasim commented Oct 25, 2023

bors r+

@metasim
Copy link
Contributor Author

metasim commented Oct 25, 2023

@lnicola thank you for the comprehensive PR review. Definitely made it better!

@bors
Copy link
Contributor

bors bot commented Oct 25, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 204e470 into georust:master Oct 25, 2023
8 checks passed
@metasim metasim deleted the fix/454 branch October 25, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CslStringList does not properly support non-key-value entries.
2 participants