-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geozero-shp release with deprecation message #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include a module level declaration so that people can see it in their compiler output, since people often don't read documentation:
Something like:
#![deprecated(note = "The geozero_shp crate has been deprecated. Instead, use geozero's built-in shapefile feature")]
@@ -1,7 +1,7 @@ | |||
[package] | |||
name = "geozero-shp" | |||
version = "0.5.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "0.5.0" | |
version = "0.5.1" |
I think this should be a patch bump - we're not breaking anything right?
Test fails because of clippy complaints... Will force merge it when both PRs are ready. |
Note to self: Release to crates.io just after next geozero release! |
Will we have to pin to a specific (old) version of geozero for this geozero_shp release? Currently it's using "workspace" |
Should be released & merged before #233