Add sync call #136
Add sync call #136
Conversation
| @@ -423,6 +423,17 @@ impl FileMut { | |||
| let (ncid, name) = super::group::get_parent_ncid_and_stem(self.ncid(), name)?; | |||
| super::variable::add_variable_from_identifiers(ncid, name, dims, T::NCTYPE) | |||
| } | |||
|
|
|||
| /// Flush pending buffers to disk to minimise data loss in case of termination. | |||
There was a problem hiding this comment.
I don't really have an HPC background, but I have trouble imagining I could trust the contents of a file after a crash without at least some kind of logging scheme.
But this is also useful to detect I/O errors that happen when closing the file, since drop isn't going to return anything.
There was a problem hiding this comment.
That's some good points you're raising. This was taken from the official documentation, and should cover crashes outside of netCDF (e.g. when computing data).
There was a problem hiding this comment.
https://danluu.com/file-consistency/ is worth a read by anyone feeling lucky enough to try to "minimize data loss" this way (of course, app crashes different from system crashes).
|
Good idea adding |
Fixes #135