Fix #101 Add convert methods for all the types from geo-types #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@x4d3 Cool! In case you didn't already see: georust/geo#718 |
|
Hi @x4d3! Thanks for the PR. I think this is a plausibly useful feature, thanks for proposing it. Funny timing - as @frewsxcv linked, we just added something very similar to the geo crate in georust/geo#718. Before commenting on any of your specific code, I wanted to strategize on the relationship between all these crates, so we don't end up re-inventing slightly different wheels. See here: #108 |
|
Closing in favor of #109 |
bors bot
added a commit
that referenced
this pull request
Feb 20, 2022
109: Port transform trait from geo and add a mutable flavor r=frewsxcv a=michaelkirk Fixes #101, #108 An alternative to #106, but as proposed in #108, I've done so by porting the [Transform trait from geo](georust/geo#718 ) to proj so that we won't need similar-but-different code in two places. I chose to double down on a trait-based approach since it seemed idiomatic to our other georust code. However, like proposed in #106, I leveraged proj_array in more places. /cc `@x4d3` corresponding PRs: - georust/geo#730 - frewsxcv/rgis#47 Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I though it would be handy/nice to be able to convert all the types from geo-types, from one system of coordinate to the other.
This PR is an attempt at doing that.
Please let me know if it's out of scope, completely wrong, etc..
Fix #101