Use unstable sort for envelopes and node reinsertion (#160)

* Use unstable sort for envelopes and node reinsertion * Add changelog entry
georust · Mar 14, 2024 · 650a901 · 650a901
1 parent 5717559
commit 650a901
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/rstar/CHANGELOG.md b/rstar/CHANGELOG.md
@@ -1,3 +1,8 @@
+# Unreleased
+
+## Changed
+- Switched to unstable sort for envelopes and node reinsertion ([PR](https://github.com/georust/rstar/pull/160))
+
 # 0.12.0
 
 ## Added

diff --git a/rstar/src/aabb.rs b/rstar/src/aabb.rs
@@ -195,7 +195,7 @@ where
     }
 
     fn sort_envelopes<T: RTreeObject<Envelope = Self>>(axis: usize, envelopes: &mut [T]) {
-        envelopes.sort_by(|l, r| {
+        envelopes.sort_unstable_by(|l, r| {
             l.envelope()
                 .lower
                 .nth(axis)

diff --git a/rstar/src/algorithm/rstar.rs b/rstar/src/algorithm/rstar.rs
@@ -335,7 +335,7 @@ where
 {
     let center = node.envelope.center();
     // Sort with increasing order so we can use Vec::split_off
-    node.children.sort_by(|l, r| {
+    node.children.sort_unstable_by(|l, r| {
         let l_center = l.envelope().center();
         let r_center = r.envelope().center();
         l_center