Read number of levels with clouds used in photolysis from config file #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizziel
added
topic: Configuration Files
9 tasks
lizziel
force-pushed
the
feature/input_photolysis_num_levs_with_clouds
branch
from
5cb776e
to
76f368b
Compare
…loud-j Updates include: - Add new Input_Opt setting Nlevs_Phot_Cloud - Set Input_Opt%Nlevs_Phot_Cloud from new setting in geoschem_config.yml photolysis menu - Move a few existing settings in input_opt_mod.F90 to photolysis menu since that is now where they are stored in geoschem_config.yml - Update all geoschem_config.yml templates. All use 34 as number of levels with clouds except CESM which uses 22. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
feature/input_photolysis_num_levs_with_clouds
branch
from
76f368b
to
e91ce06
Compare
|
Integration tests are running |
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #14397c6 GEOS-Chem submod update: Merge PR #2363 (Update setCommonRunSettings.sh)
GEOS-Chem #f78052f59 Merge PR #2342 (Read number of levels with clouds into Cloud-J)
HEMCO #2192e0e HEMCO 3.9.1 release
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 39073394
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All tests were zero-diff w/r/t PR #2363 except:
|
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #9c77f30 GEOS-Chem submod update: Merge PR #2363 (Update setCommonRunSettings.sh)
GEOS-Chem #f78052f59 Merge PR #2342 (Read number of levels with clouds into Cloud-J)
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 39073425
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Also, all tests were zero-diff w/r/t PR #2363. |
Merged
msulprizio
added a commit
that referenced
this pull request
Jul 19, 2024
We now run a 2x2.5 ModelE2.1 (aka GCAP 2.0) full-chemistry simulation in the GCClassic integration tests. Only one scenario (SSP2-4.5) is evaluated here simply to ensure these future scenario simulations compile and run for 1 hour successfully. I will defer to @ltmurray for guidance on whether additional simulations are needed. The GCAP 2.0 integration test is passing off of 14.4.1, confirming that the fixes in #2342 should have resolved the issues of GCAP 2.0 not working in 14.0.0 (as reported by Lee Murray at IGC11). Sample integration test output: ``` ============================================================================== GEOS-Chem Classic: Execution Test Results GCClassic #c49fcec Submod updates: Merge GEOS-Chem PR #2353 and Cloud-J PR #19 GEOS-Chem #7e4001658 Merge PR #2369 (Fix several issues with satellite diagnostics) HEMCO #2192e0e HEMCO 3.9.1 release Using 24 OpenMP threads Number of execution tests: 29 Submitted as SLURM job: 40462513 ============================================================================== Execution tests: ------------------------------------------------------------------------------ gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS gc_2x25_ModelE2.1_fullchem..........................Execute Simulation....PASS ``` Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
lizziel
pushed a commit
that referenced
this pull request
Jul 30, 2024
We now run a 2x2.5 ModelE2.1 (aka GCAP 2.0) full-chemistry simulation in the GCClassic integration tests. Only one scenario (SSP2-4.5) is evaluated here simply to ensure these future scenario simulations compile and run for 1 hour successfully. I will defer to @ltmurray for guidance on whether additional simulations are needed. The GCAP 2.0 integration test is passing off of 14.4.1, confirming that the fixes in #2342 should have resolved the issues of GCAP 2.0 not working in 14.0.0 (as reported by Lee Murray at IGC11). Sample integration test output: ``` ============================================================================== GEOS-Chem Classic: Execution Test Results GCClassic #c49fcec Submod updates: Merge GEOS-Chem PR #2353 and Cloud-J PR #19 GEOS-Chem #7e4001658 Merge PR #2369 (Fix several issues with satellite diagnostics) HEMCO #2192e0e HEMCO 3.9.1 release Using 24 OpenMP threads Number of execution tests: 29 Submitted as SLURM job: 40462513 ============================================================================== Execution tests: ------------------------------------------------------------------------------ gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS gc_2x25_ModelE2.1_fullchem..........................Execute Simulation....PASS ``` Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR addresses the issue of hard-coding number of levels with cloud within Cloud-J photolysis. It fixes a bug where you can only use Cloud-J in GEOS-Chem at 72 levels. It goes with Cloud-J PR geoschem/Cloud-J#17 which now accepts this parameter from parent models.
Updates include:
Input_OptsettingNlevs_Phot_CloudInput_Opt%Nlevs_Phot_Cloudfrom new setting ingeoschem_config.ymlphotolysis menuinput_opt_mod.F90to photolysis menu since that is now where they are stored ingeoschem_config.ymlgeoschem_config.ymltemplates to include the new parameter.Expected changes
This is a zero diff update.
Reference(s)
None
Required companion PRs
geoschem/Cloud-J#17
Related Github issues
geoschem/Cloud-J#16