Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify for annotations is showing all internal properties rather than title/description #7332

Closed
1 task done
allyoucanmap opened this issue Sep 20, 2021 · 4 comments
Closed
1 task done

Identify for annotations is showing all internal properties rather than title/description #7332

allyoucanmap opened this issue Sep 20, 2021 · 4 comments
Assignees
@allyoucanmap @ElenaGallo
Labels
Accepted bug geonode_integration Good first issue Internal Priority: High
Milestone
2021.02.00

Comments

@allyoucanmap
Copy link
Contributor

Description

The annotation is showing the default identify viewer with all the internal properties of the feature.

How to reproduce

Expected Result

  • the identify popup should show only the needed information without the editing buttons if the Annotation plugin is not included

image

default viewer in map:

image

Current Result

  • The annotation shows info such as visibility and id and the viewer is different from the one displayed in the default map viewer

image

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

It seems that the custom viewer for annotations is included only if the Annotations plugin is in localConfig in particular it needs to include the reducers and the addAnnotationsLayerEpic epic
@tdipisa tdipisa added this to the 2021.02.01 milestone Sep 20, 2021
@tdipisa tdipisa self-assigned this Sep 20, 2021
@giohappy giohappy mentioned this issue Sep 22, 2021
Closed
@allyoucanmap allyoucanmap self-assigned this Sep 24, 2021
@tdipisa tdipisa removed their assignment Sep 24, 2021
@allyoucanmap
Copy link
Contributor Author

@tdipisa @giohappy Proposal:

  • change the default properties response similar to the one presented by annotation to keep a UI consistency between responses

before

image
image

after

image
image

  • add a layer property to include only a list of properties (eg includeInfoProperties: [ 'title', 'description' ])

@giohappy
Copy link
Contributor

It's fine to me but I leave the final decision to the frontend team (@tdipisa)

@tdipisa
Copy link
Member

tdipisa commented Sep 27, 2021

+1 @allyoucanmap

@allyoucanmap allyoucanmap mentioned this issue Oct 13, 2021
Merged
5 tasks
dsuren1 pushed a commit that referenced this issue Oct 13, 2021
@allyoucanmap
#7332: Identify for annotations is showing all internal properties ra…
88a2e6e 
…ther than title/description (#7443)

* refactor of identify property viewer

* remove properties from vector map info

* remove hideToolbar prop
@tdipisa tdipisa modified the milestones: 2021.02.01, 2021.02.00 Oct 13, 2021
@ElenaGallo ElenaGallo self-assigned this Oct 14, 2021
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Oct 14, 2021
@allyoucanmap
geosolutions-it#7332: Identify for annotations is showing all interna…
3ab6b1a 
…l properties rather than title/description (geosolutions-it#7443)

* refactor of identify property viewer

* remove properties from vector map info

* remove hideToolbar prop
@allyoucanmap allyoucanmap mentioned this issue Oct 14, 2021
Merged
5 tasks
tdipisa pushed a commit that referenced this issue Oct 14, 2021
@allyoucanmap
#7332: Identify for annotations is showing all internal properties ra…
ed1256c 
…ther than title/description (#7443) (#7448)

* refactor of identify property viewer

* remove properties from vector map info

* remove hideToolbar prop
@tdipisa
Copy link
Member

tdipisa commented Oct 14, 2021

@ElenaGallo Backport merged in QA, please keep an eye on tests this there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

@ElenaGallo ElenaGallo

Labels
Accepted bug geonode_integration Good first issue Internal Priority: High
Projects
None yet
Milestone
2021.02.00
Development

No branches or pull requests
4 participants
@giohappy @tdipisa @allyoucanmap @ElenaGallo